-
Notifications
You must be signed in to change notification settings - Fork 168
feat(ZonalBuckets): add support for generation=0 to avoid overwriting existing objects and add is_stream_open support
#1709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…bjectWriter for stream status check
Summary of ChangesHello @chandra-siri, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new public property, Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new public property is_stream_open to the AsyncAppendableObjectWriter class. This change improves the class's public API by providing a clear way to check if the underlying stream is open. The tests have been updated accordingly to use this new property, which is good practice. My review includes one suggestion to improve consistency in the test suite.
…ng existing objects
is_stream_open property to AsyncAppendableObjectWriter for stream status checkis_stream_open support
is_stream_open support generation=0 to avoid overwriting existing objects and add is_stream_open support
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…iter and _AsyncWriteObjectStream - Updated documentation to clarify behavior when using generation=0 and None. - Added tests to verify correct handling of object creation and overwriting based on generation settings.
feat(ZonalBuckets): add support for
generation=0to prevent overwriting existing objectsfeat(ZonalBuckets): add
is_stream_openproperty to AsyncAppendableObjectWriter for stream status check