Skip to content

Conversation

@chandra-siri
Copy link
Collaborator

@chandra-siri chandra-siri commented Jan 16, 2026

feat(ZonalBuckets): add support for generation=0 to prevent overwriting existing objects
feat(ZonalBuckets): add is_stream_open property to AsyncAppendableObjectWriter for stream status check

@chandra-siri chandra-siri requested review from a team as code owners January 16, 2026 12:08
@chandra-siri chandra-siri enabled auto-merge (squash) January 16, 2026 12:08
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/python-storage API. labels Jan 16, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @chandra-siri, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new public property, is_stream_open, to the AsyncAppendableObjectWriter class. This enhancement provides a standardized and accessible way for external code to query the current status of the object writing stream, improving encapsulation and maintainability. The accompanying test updates ensure that the new property is correctly integrated and utilized.

Highlights

  • New Public Property: A new public property is_stream_open has been added to the AsyncAppendableObjectWriter class, providing a clear interface to check the internal stream status.
  • Encapsulation Improvement: This property exposes the private _is_stream_open attribute, improving encapsulation by providing a controlled way to access the stream's state.
  • Test Updates: Existing unit tests have been updated to utilize the new is_stream_open property, ensuring its correct usage and validating its functionality.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new public property is_stream_open to the AsyncAppendableObjectWriter class. This change improves the class's public API by providing a clear way to check if the underlying stream is open. The tests have been updated accordingly to use this new property, which is good practice. My review includes one suggestion to improve consistency in the test suite.

@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Jan 16, 2026
@chandra-siri chandra-siri changed the title feat(ZonalBuckets): add is_stream_open property to AsyncAppendableObjectWriter for stream status check feat(ZonalBuckets): add support for generation=0 to avoid overwriting existing objects and add is_stream_open support Jan 16, 2026
@chandra-siri chandra-siri changed the title feat(ZonalBuckets): add support for generation=0 to avoid overwriting existing objects and add is_stream_open support feat(ZonalBuckets): add support for generation=0 to avoid overwriting existing objects and add is_stream_open support Jan 16, 2026
chandra-siri and others added 2 commits January 16, 2026 18:06
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…iter and _AsyncWriteObjectStream

- Updated documentation to clarify behavior when using generation=0 and None.
- Added tests to verify correct handling of object creation and overwriting based on generation settings.
@chandra-siri chandra-siri merged commit ea0f5bf into main Jan 16, 2026
18 checks passed
@chandra-siri chandra-siri deleted the generation_match_and_stream_open branch January 16, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/python-storage API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants