Skip to content

feat: make all and any compatible with integer columns on Polars session #2154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 43 commits into
base: main
Choose a base branch
from
Open

feat: make all and any compatible with integer columns on Polars session #2154

wants to merge 43 commits into from
+5,053 −11

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Oct 8, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

tswast added 27 commits October 7, 2025 21:54
@tswast
docs: remove import bigframes.pandas as bpd boilerplate from many sam…
8cfaca6 
…ples

Also, fixes several constructors that didn't take a session for
compatibility with multi-session applications.
@tswast
fix docs
c85d47f
@tswast
fix unit tests
78bfccf
@tswast
skip sklearn test
210dc9a
@tswast
fix snapshot
bed4069
@tswast
Merge branch 'main' into tswast-doctest-boilerplate
aa23fca
@tswast
plumb through session for from_tuples and from_arrays
20cae2d
@tswast
Merge remote-tracking branch 'origin/main' into tswast-doctest-boiler…
f57a8c3 
…plate
@tswast
Merge remote-tracking branch 'origin/tswast-doctest-boilerplate' into…
d8ab16b 
… tswast-doctest-boilerplate
@tswast
add from_frame
1dc648b
@tswast
make sure polars session isnt skipped on Kokoro
9de6f9f
@tswast
fix apply doctest
5d23dee
@tswast
make doctest conftest available everywhere
20d7c27
@tswast
Merge remote-tracking branch 'origin/main' into tswast-doctest-boiler…
534471e 
…plate
@tswast
add python version flexibility for to_dict
fbe606e
@tswast
disambiguate explicit names
171f3ec
@tswast
disambiguate explicit name none versus no name
ded5c1e
@tswast
fix for column name comparison in pandas bin op
841bc64
@tswast
avoid setting column labels in special case of Series(block)
81f49a6
@tswast
Merge remote-tracking branch 'origin/main' into tswast-polars-session…
f7a017a 
…-names
@tswast
revert doctest changes
5b60505
@tswast
revert doctest changes
a97cc93
@tswast
revert df docstrings
5aaacfe
@tswast
add polars series unit tests
922bbf4
@tswast
restore a test
765b678
@tswast
Revert "restore a test"
4aa47a8 
This reverts commit 765b678.
@tswast
skip null
f75f5bf
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Oct 8, 2025
@tswast tswast marked this pull request as ready for review October 8, 2025 22:30
@tswast tswast requested review from a team as code owners October 8, 2025 22:30
@tswast tswast requested a review from shuoweil October 8, 2025 22:30
tswast
tswast commented Oct 9, 2025
View reviewed changes
tests/unit/test_series_polars.py
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage failure. I think I should add # pragma: no cover to the currently skipped tests.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I think it's the new methods on Session. Created #2157 which splits out that part and actually fixes a bug in the to_timedelta implementation.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this file is a nearly exact copy of the tests/system/small/test_series.py file with additional fixtures for unit testing.

@tswast tswast mentioned this pull request Oct 9, 2025
Merged
@tswast
Copy link
Collaborator Author

tswast commented Oct 10, 2025

Failures appear unrelated.

e2e failure tests/system/large/blob/test_function.py::test_blob_transcribe[gemini-2.0-flash-lite-001-True]

samples failure multimodal_test.py::test_multimodal_dataframe - google.api_core.except...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shuoweil shuoweil Awaiting requested review from shuoweil shuoweil is a code owner automatically assigned from googleapis/api-bigquery-dataframe

At least 1 approving review is required to merge this pull request.

Assignees

@ericfe-google ericfe-google

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xl Pull request size is extra large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tswast @ericfe-google