perf: Default to interactive display for SQL in anywidget mode #2138
Conversation
product-auto-label
bot
added
size: s
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
product-auto-label
bot
added
size: m
|
|
||
| widget = display.TableWidget(self.copy()) | ||
| return widget._repr_html_() # Return widget's HTML representation | ||
| except (AttributeError, ValueError, ImportError): |
There was a problem hiding this comment.
Why are we catching so many exceptions here?
There was a problem hiding this comment.
We are catching those exceptions to handle cases where the interactive anywidget table can't be displayed.
anywidget is an optional install, so we have to catch the ImportError in case someone doesn't have it. It also only works in environments like a Jupyter notebook, so if you run the code in a regular script, it can throw an AttributeError or ValueError.
That try...except block is just a safety net. It lets us fall back to the basic table view instead of crashing the program if the setup isn't perfect for the fancier, interactive one.
shuoweil
force-pushed
the
shuowei-anywidget-col
branch
from
dfa9c03 to
43a938c
Compare
Previously, SQL queries in anywidget mode would fall back to deferred execution, showing a dry run instead of an interactive table. This change modifies the display logic to directly use the anywidget interactive display for SQL queries, providing a more consistent and responsive user experience. A test case has been added to verify this behavior.
Adds a test case to verify that a DataFrame with a STRUCT column is correctly displayed in anywidget mode. This test confirms that displaying a STRUCT column does not raise an exception that would trigger the fallback to the deferred representation. It mocks `IPython.display.display` to capture the `TableWidget` instance and asserts that the rendered HTML contains the expected string representation of the STRUCT data.
shuoweil
force-pushed
the
shuowei-anywidget-col
branch
from
43a938c to
4a33ccf
Compare
2 participants
Previously, SQL queries in anywidget mode would fall back to deferred execution, showing a dry run instead of an interactive table.
This change modifies the display logic to directly use the anywidget interactive display for SQL queries, providing a more consistent and responsive user experience. A test case has been added to verify this behavior.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<448126500> 🦕