Skip to content

Conversation

shuoweil
Copy link
Contributor

@shuoweil shuoweil commented Aug 25, 2025

Here are the changes:

  1. Added bool type support
  2. Added verbose parameter to all blob functions - When verbose=True, functions return a structured response with both status (error messages) and content fields. When verbose=False, they return only the content
  3. Enhanced error handling - All functions now wrap their core logic in try-catch blocks and return structured error information.
  4. Updated return types - Functions that previously returned bytes now return str (base64-encoded) to support the structured JSON response format.
  5. Updated API interfaces - All blob accessor methods (exif, image_blur, image_resize, image_normalize, pdf_extract, pdf_chunk) now accept the verbose parameter and handle the structured responses appropriately.
  6. Comprehensive test coverage - Added parametrized tests for both verbose modes across all blob functions.

Fixes #<403365429> 🦕

@shuoweil shuoweil requested review from a team as code owners August 25, 2025 22:43
@shuoweil shuoweil requested a review from chelsea-lin August 25, 2025 22:43
@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Aug 25, 2025
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Aug 25, 2025
@shuoweil shuoweil marked this pull request as draft August 25, 2025 22:44
@shuoweil shuoweil removed the request for review from chelsea-lin August 25, 2025 22:44
@shuoweil shuoweil assigned shuoweil and unassigned shobsi Aug 25, 2025
@shuoweil shuoweil force-pushed the shuowei-add-error-handling branch 2 times, most recently from 90e7d33 to cde2a61 Compare September 19, 2025 01:57
@shuoweil shuoweil force-pushed the shuowei-add-error-handling branch 2 times, most recently from 32fa87c to 623f9ba Compare October 10, 2025 03:36
@shuoweil shuoweil marked this pull request as ready for review October 10, 2025 03:37
@shuoweil shuoweil requested review from GarrettWu and sycai October 10, 2025 03:37
@shuoweil shuoweil force-pushed the shuowei-add-error-handling branch from 623f9ba to 1a873bc Compare October 11, 2025 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xl Pull request size is extra large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants