fix: Refine connectivity metric for RPCs that receive no response and sent to Transport layer #4220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
surbhigarg92
force-pushed
the
connectivity_metrics
branch
from
8142951 to
d35b81c
Compare
surbhigarg92
force-pushed
the
connectivity_metrics
branch
from
4d45e98 to
aa7e823
Compare
Collaborator
|
@surbhigarg92 nit: Can you please update the PR title? it should reflect little more on what are you trying to fix since it comes in the release tag |
surbhigarg92
changed the title
Contributor
Author
Done |
| */ | ||
| package com.google.cloud.spanner; | ||
|
|
||
| import io.grpc.ClientStreamTracer; |
Collaborator
There was a problem hiding this comment.
This is an experimental API right? Until tracer is launched, we can't use it right? https://github.com/grpc/grpc-java/blob/master/api/src/main/java/io/grpc/ClientStreamTracer.java#L27
| return new SimpleForwardingClientCall<ReqT, RespT>(next.newCall(method, callOptions)) { | ||
| final AtomicBoolean headersReceived = new AtomicBoolean(false); | ||
| SpannerGrpcStreamTracer streamTracer = new SpannerGrpcStreamTracer(); | ||
| CallOptions newOptions = |
Collaborator
There was a problem hiding this comment.
Does customer have access to CallOptions? If yes, We need to make sure we are not overriding withStreamTracerFactory which is set by the customer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the connectivity error metrics in the Java Spanner client library to provide a more accurate and comprehensive tracking of network-related issues.
Description:
The current connectivity error metric is only incremented in the rare event that a response header is received from the server but lacks GFE/AFE server timing latency. This limitation means that more common and critical connectivity problems are not captured, such as:
To address this gap, this change updates the logic to also capture RPCs that have been passed to the gRPC transport layer but for which no response is received. This will result in a more accurate and reliable connectivity error metric.
Note Client-side timeouts that occur before an RPC is sent to the transport layer are explicitly excluded from this metric.