style: add Error Prone and suppress existing errors #3621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
schcamille
changed the title
schcamille
force-pushed
the
errorprone
branch
from
e92537a to
c2ee8a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Errorprone and suppress warnings as appropriate.
I have suppressed a few checks using flags, namely
CheckReturnValue,ProtoBuilderReturnValueIgnoredandReturnValueIgnoredbecause the errors looked like false positives/less useful. I've also fixed some errors when it was very straightforward.The suppressed errors can be fixed in later commits/PRs but at least new code is covered.
This PR should be a no-op in term of actual code behaviour and runtime execution.
Fixes #3620 ☕️