-
Notifications
You must be signed in to change notification settings - Fork 130
[README] Update Thanks section #2766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @joshlf, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the project's documentation by updating the 'Thanks' section. The change specifically removes a reference to Amazon from the list of maintainers, ensuring that the project's attribution accurately reflects the current maintenance structure in both the main README and the library's internal documentation. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the 'Thanks' section in the documentation. The change itself is correct. I've added a suggestion to improve the line wrapping for better readability. Please also ensure that README.md is regenerated using the provided script after updating src/lib.rs, as per the repository's contribution guidelines.
| //! Zerocopy is maintained by engineers at Google with help from [many wonderful | ||
| //! contributors][contributors]. Thank you to everyone who has lent a hand in | ||
| //! making Rust a little more secure! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better readability, could you please re-wrap these lines to be more balanced? After making this change, please remember to regenerate README.md by running cargo -q run --manifest-path tools/Cargo.toml -p generate-readme > README.md as mentioned in the file header.
//! Zerocopy is maintained by engineers at Google with help from
//! [many wonderful contributors][contributors]. Thank you to everyone
//! who has lent a hand in making Rust a little more secure!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2766 +/- ##
=======================================
Coverage 88.89% 88.89%
=======================================
Files 20 20
Lines 5423 5423
=======================================
Hits 4821 4821
Misses 602 602 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.