Add secret manager in weather-dl. #374
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahrsee1997
reviewed
Jul 31, 2023
mahrsee1997
reviewed
Jul 31, 2023
alxmrs
reviewed
Aug 1, 2023
Comment on lines
-202
to
+201
| api_url=UUUUU1 | ||
| secret_key=projects/PROJECT_NAME/secrets/SECRET_NAME/versions/1 |
There was a problem hiding this comment.
Please add a separate section that demos secrets mgr. Users should see examples of both ways of adding keys.
alxmrs
reviewed
Aug 1, 2023
| return target | ||
|
|
||
|
|
||
| def get_secret(secret_key: str) -> t.Dict: |
There was a problem hiding this comment.
Optional: please return a t.TypedDict so we know what keys to look for.
alxmrs
reviewed
Aug 1, 2023
Comment on lines
+492
to
+496
| secret_key=projects/PROJECT_NAME/secrets/SECRET_NAME/versions/1 | ||
| [parameters.bob] | ||
| api_key=KKKKK2 | ||
| api_url=UUUUU2 | ||
| secret_key=projects/PROJECT_NAME/secrets/SECRET_NAME/versions/1 | ||
| [parameters.eve] | ||
| api_key=KKKKK3 | ||
| api_url=UUUUU3 | ||
| secret_key=projects/PROJECT_NAME/secrets/SECRET_NAME/versions/1 |
alxmrs
reviewed
Aug 1, 2023
| ``` | ||
| """ | ||
| return [(name, params) for name, params in config.kwargs.items() | ||
| return [(name, get_secret(params.get('secret_key'))) for name, params in config.kwargs.items() |
There was a problem hiding this comment.
We should support both API keys and secrets manager.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #368.