This repository was archived by the owner on Nov 9, 2023. It is now read-only.
Remove Bad CLA response test as some authenticator only support 1 logical channel on NFC#144
Open
qingzhang001 wants to merge 1 commit intogoogle:masterfrom
Open
Remove Bad CLA response test as some authenticator only support 1 logical channel on NFC#144qingzhang001 wants to merge 1 commit intogoogle:masterfrom
qingzhang001 wants to merge 1 commit intogoogle:masterfrom
Conversation
…ical channel on NFC If authenticator only support 1 logical channel on NFC, it will ignore the channel number in class byte and direct to applet selected. Multi channel on NFC in authenticator is not FIDO requirement, so test removed
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
cpiper
force-pushed
the
master
branch
4 times, most recently
from
8590f57 to
14205c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If authenticator only support 1 logical channel on NFC, it will ignore
the channel number in class byte and direct to applet selected. Multi
channel on NFC in authenticator is not FIDO requirement, so test removed