Skip to content

Disable setting specific profiler options on Pathways backend. #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2025
Merged

Disable setting specific profiler options on Pathways backend. #494

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions tunix/sft/profiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ class ProfilerOptions:
skip_first_n_steps: int
# Number of steps to profile.
profiler_steps: int
# Whether to set the profile options.
set_profile_options: bool = True
# https://github.com/jax-ml/jax/blob/0b1b909dd66a113ee0d7e54e55d0efef480e2a8a/docs/profiling.md?plain=1#L285
host_tracer_level: int = 2 # set to 2 to capture HBM profiles.
# https://github.com/jax-ml/jax/blob/0b1b909dd66a113ee0d7e54e55d0efef480e2a8a/docs/profiling.md?plain=1#L300
Expand Down Expand Up @@ -69,14 +71,19 @@ def maybe_activate(self, step: int):
if self._do_not_profile or step != self._first_profile_step:
return
logging.info("Starting JAX profiler at step %d.", step)
profile_options = jax.profiler.ProfileOptions()
profile_options.host_tracer_level = self._profiler_options.host_tracer_level
profile_options.python_tracer_level = (
self._profiler_options.python_tracer_level
)
jax.profiler.start_trace(
log_dir=self._output_path, profiler_options=profile_options
)
if self._profiler_options.set_profile_options:
profile_options = jax.profiler.ProfileOptions()
profile_options.host_tracer_level = (
self._profiler_options.host_tracer_level
)
profile_options.python_tracer_level = (
self._profiler_options.python_tracer_level
)
jax.profiler.start_trace(
log_dir=self._output_path, profiler_options=profile_options
)
else:
jax.profiler.start_trace(log_dir=self._output_path)

def maybe_deactivate(self, step: int):
"""End the profiler."""
Expand Down