Fix silent data loss in add_index for unsupported dtypes#440
Open
Tanmay-24 wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
The add_index C++ implementation was silently returning when encountering numpy arrays with unsupported dtypes (like float64), causing 0 events in the output instead of raising an error. Moved the return statement inside the 'S' dtype branch so unsupported array types fall through to the error handler. Added regression test for float column index. Fixes google#437
Tanmay-24
force-pushed
the
fix/add-index-silent-failure
branch
from
421d969 to
722958e
Compare
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #437
The
add_index()operation was silently returning 0 events when the index column had an unsupported numpy dtype (e.g., unicode strings with dtype kind'U').Root Cause
In
add_index.cclines 221-228, when a numpy array's dtype kind was not'S'(bytes), the function would return without processing the feature OR raising an error, leaving the group accumulator empty.Fix
Moved the
returnstatement inside theif (dtype().kind() == 'S')block so that unsupported array dtypes fall through to the error handler that throwsstd::invalid_argument("Non supported feature type").