Fix memory safety vulnerabilities (OOB Read & Integer Overflow)#86
Open
izumi-hyun wants to merge 1 commit into
Open
Fix memory safety vulnerabilities (OOB Read & Integer Overflow)#86izumi-hyun wants to merge 1 commit into
izumi-hyun wants to merge 1 commit into
Conversation
Fixed two memory safety vulnerabilities identified during security research: 1. Out-of-bounds read in ExtractUserAgent (added length bounds checking). 2. Integer overflow in Matches (refactored numpos to size_t).
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This Pull Request improves robustness in two areas of
robots.ccthat were identified during fuzzing and code review.Changes
1. Boundary validation in
ExtractUserAgentAdds an explicit
p < endcheck while iterating through thestring_view.This ensures parsing remains constrained to the logical bounds of the provided view and avoids processing bytes beyond the intended range.
2. Integer overflow hardening in
MatchesReplaces
int-based counters derived from path length withsize_t.This removes potential overflow edge cases when handling extremely large inputs and improves consistency with the surrounding container and length types.
Notes
The previously discussed matching-complexity and percent-encoding consistency observations are not included in this PR, as they may require broader design discussion and separate evaluation.
Validation
All existing 21 unit tests in
robots_test.ccpass successfully with these changes.