Skip to content

Remove type hints from MCP tool docstrings#226

Draft
dandye wants to merge 1 commit intomainfrom
remove-docstring-type-hints-12213284078439305745
Draft

Remove type hints from MCP tool docstrings#226
dandye wants to merge 1 commit intomainfrom
remove-docstring-type-hints-12213284078439305745

Conversation

@dandye
Copy link
Collaborator

@dandye dandye commented Jan 29, 2026

This PR removes type hints from the docstrings of all MCP tool functions in the server/secops/secops_mcp/tools/ directory, while keeping the argument descriptions and function signature type hints intact. This ensures a cleaner docstring format that is easier to read and maintain, while still providing type information via the function definition itself.

Key changes:

  • Removed (Type) hints from Args: sections in all tool files.
  • Fixed indentation in server/secops/secops_mcp/tools/security_alerts.py to consistently use 8 spaces for arguments.
  • Verified changes by running existing unit tests.

PR created automatically by Jules for task 12213284078439305745 started by @dandye

Removed type hints from the `Args` section of docstrings in all MCP tool functions located in `server/secops/secops_mcp/tools/`.
This aligns the docstring format with the preferred style (e.g., `arg: Description` instead of `arg (Type): Description`).
The function signatures retain their type hints.
Also corrected indentation inconsistencies in `security_alerts.py`.

Co-authored-by: dandye <121151+dandye@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@dandye dandye requested a review from a team January 29, 2026 10:33
@dandye dandye marked this pull request as draft January 29, 2026 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant