Skip to content

No public description #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
+26 −2
Open

No public description #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions maldoca/js/ir/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
load("@llvm-project//mlir:tblgen.bzl", "gentbl_cc_library", "td_library")
load("@rules_cc//cc:cc_binary.bzl", "cc_binary")
load("@rules_cc//cc:cc_library.bzl", "cc_library")
load("@rules_python//python:defs.bzl", "py_binary")
load("//maldoca/js:allowed_users.bzl", "JSIR_ALLOWED_USERS")

licenses(["notice"])
Expand Down Expand Up @@ -378,3 +379,14 @@ filegroup(
"@llvm-project//llvm:FileCheck",
],
)

py_binary(
name = "generate_tests",
srcs = ["generate_tests.py"],
data = [
":jsir_gen",
],
deps = [
"@pypi//tqdm",
],
)
4 changes: 2 additions & 2 deletions maldoca/js/ir/analyses/constant_propagation/analysis.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,10 +193,10 @@ void JsirConstantPropagationAnalysis::VisitOpDefault(

// Merge in the result of the fold, either a constant or a value.
mlir::OpFoldResult fold_result = std::get<1>(it);
if (auto attr = fold_result.dyn_cast<mlir::Attribute>()) {
if (auto attr = llvm::dyn_cast<mlir::Attribute>(fold_result)) {
result.Join(JsirConstantPropagationValue{attr});
} else {
auto result_value = fold_result.get<mlir::Value>();
auto result_value = llvm::cast<mlir::Value>(fold_result);
auto result_state_ref = GetStateAt(result_value);
result.Join(result_state_ref.value());
}
Expand Down
8 changes: 8 additions & 0 deletions maldoca/js/ir/generate_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,18 @@
`test_config.json` found in the scanned directory.
Usage:
# Option 1: Direct Python
python3 maldoca/js/ir/generate_tests.py <directory_to_scan>
# Option 2: Blaze build and execute binary
bazel build //maldoca/js/ir:generate_tests
./bazel-bin/maldoca/js/ir/generate_tests <directory_to_scan>
Example:
python3 maldoca/js/ir/generate_tests.py maldoca/js/ir
# or
bazel build //maldoca/js/ir:generate_tests
./bazel-bin/maldoca/js/ir/generate_tests maldoca/js/ir
"""

import argparse
Expand Down
1 change: 1 addition & 0 deletions requirements.in
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
# TODO(tzx): Seems unnecessary.
# lit==18.1.8
tqdm
3 changes: 3 additions & 0 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,6 @@
#
# pip-compile requirements.in
#
tqdm==4.67.1
# via -r requirements.in

Loading