Skip to content

Fix affine-related bugs in split-preprocessing - #3327

Merged
copybara-service[bot] merged 1 commit into
mainfrom
alex/affine-fix
Aug 11, 2026
Merged

Fix affine-related bugs in split-preprocessing#3327
copybara-service[bot] merged 1 commit into
mainfrom
alex/affine-fix

Conversation

@AlexanderViand

@AlexanderViand AlexanderViand commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

This came up as part of #3305 which is basically unrelated, but happened to surface these issues.
🤖-driven fixes but looking reasonable to me.

@j2kun j2kun left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash and we'll get it in!

* test noncanonical affine loop indices

* normalize affine loops before splitting

* drop dead affine.for iter_args

Co-authored-by: Marc Desgroseilliers <marc.desgroseilliers@belfortlabs.com>
@AlexanderViand

Copy link
Copy Markdown
Collaborator Author

Please squash and we'll get it in!

@j2kun done!

@j2kun j2kun added the pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing label Aug 11, 2026
@copybara-service
copybara-service Bot merged commit 0f1bf99 into main Aug 11, 2026
20 checks passed
@copybara-service
copybara-service Bot deleted the alex/affine-fix branch August 11, 2026 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants