improve handling of padding for conv1d - #3303
Merged
Merged
Conversation
Collaborator
Author
|
Once we agree on the basic structure, I can port this to the 2d version |
j2kun
reviewed
Aug 6, 2026
j2kun
left a comment
j2kun
left a comment
Collaborator
There was a problem hiding this comment.
I was considering this today, because indeed I found a bug with the hotword compilation in that it was dropping the padding op completely (!!), and then I refreshed an old change that supports padding.
I agree the best thing to do is to combine the conv op with its prior padding and treat is as a joint kernel. I feel a slight preference to do this fusion as a separate op + pass, but the change here is pretty solid and I think we can just go with this for a while.
j2kun
approved these changes
Aug 6, 2026
j2kun
added
the
pull_ready
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issues with the padding where it was not consistently handled