fix: fix ckks.rescale verifier to use exact log2 on expected scale factor - #3197
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_948350422
branch
from
July 15, 2026 17:11
3888e1f to
797bbb7
Compare
…ctor This fixes a small issue where a q prime was chosen such that APInt::nearestLog2 calculates 23 when the log2 was 23.56... and it caused the ckks.rescale verifier to emit an error that the expected rescale was not dropping 24 bits. PiperOrigin-RevId: 948413937
copybara-service
Bot
force-pushed
the
test_948350422
branch
from
July 15, 2026 17:32
797bbb7 to
26e049a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: fix ckks.rescale verifier to use exact log2 on expected scale factor
This fixes a small issue where a q prime was chosen such that APInt::nearestLog2 calculates 23 when the log2 was 23.56... and it caused the ckks.rescale verifier to emit an error that the expected rescale was not dropping 24 bits.