Make rotation analysis more robust for loops with if statements - #2788
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_885851705
branch
6 times, most recently
from
March 20, 2026 00:20
4424d31 to
fc7fe8e
Compare
Here the problem was that, for more complicated looped kernels, the rotation analysis was not evaluating the loop correctly. The previous implementation was trying to skip various intermediate operations on tensors/ciphertexts, but this causes the DAG to be disconnected and so the loop's yield may not end up being visited, so that it doesn't proceed to the next iteration and truncates the rotations at the first one found (without these changes, the if_else.mlir test will only annotate with the index 512). PiperOrigin-RevId: 886472605
copybara-service
Bot
force-pushed
the
test_885851705
branch
from
March 20, 2026 01:02
fc7fe8e to
a471a80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make rotation analysis more robust for loops with if statements
Here the problem was that, for more complicated looped kernels,
the rotation analysis was not evaluating the loop correctly.
The previous implementation was trying to skip various intermediate
operations on tensors/ciphertexts, but this causes the DAG to be disconnected
and so the loop's yield may not end up being visited, so that it doesn't
proceed to the next iteration and truncates the rotations at the first
one found (without these changes, the if_else.mlir test will only annotate with
the index 512).