fix: rewrite avg pool as 2-d nchw fchw convolution - #2772
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_884566739
branch
4 times, most recently
from
March 24, 2026 15:58
1f416bf to
7d8d7c1
Compare
This fixes the bug where before the avg pooling was split into per-channel 2d convolutions, but that was incorrect since that doesn't properly compute the average since linalg.conv_2d doesnt support striding. This temporarily disables lenet since that includes the pooling layer Fixes #2702 PiperOrigin-RevId: 888710468
copybara-service
Bot
force-pushed
the
test_884566739
branch
from
March 24, 2026 16:38
7d8d7c1 to
a6e793a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: rewrite avg pool as 2-d nchw fchw convolution
This fixes the bug where before the avg pooling was split into per-channel 2d convolutions, but that was incorrect since that doesn't properly compute the average since linalg.conv_2d doesnt support striding.
This temporarily disables lenet since that includes the pooling layer
Fixes #2702