-
Notifications
You must be signed in to change notification settings - Fork 3.4k
[Python] Improve python API #8781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
satur9nine
commented
Nov 16, 2025
- Make the Python API similar to Rust and Swift for improved usability
de2272c to
0c71177
Compare
0c71177 to
e5a601a
Compare
|
@satur9nine I've got this on my list! Will look it over sometime in the next few days 🤞 |
77e604a to
5c7a3a2
Compare
|
@fliiiix this seems like a good improvement but as always I enjoy an extra opinion :D |
f933113 to
fc2bab6
Compare
|
I had a quick look can you also split up this change in multiple commits but on MR is fine? (You can just force push them on this MR) |
OK I split it up into multiple commits. Do you know how to confirm the |
44adff2 to
8882c4b
Compare
Make StartVector vector public since it is already being used in generated code
Makes Python API for vectors cleaner like Rust and Swift
8882c4b to
62ebcd6
Compare
|
I'm away for the next few days and i didn't manage to review this in detail but it seems ok enough to get merged and if there are problems we can deal with them later 🤷
Visual inspection of the pyi file and then there is a way if they are in the correct location mypy will also pick them up. I realized when i looked again at this change that the types are now in the py file and the pyi file if im not mistaken the types should end up only in the pyi files. (I would not remove them in this MR from the py file, and i need to look up the discussion again about that topic, but i think that should be a new MR) |