[Java] Use Table's fully qualified path

[nevi-me]

When a table's name is called Table, the Java bindings generated result in an error due to there being 2 Tables. This fixes the issue by fully qualifyng the flatbuffers Table import.

Fixes #8728

[bjornharrtell]

@nevi-me why the alias _Vector for Vector?

[maxburke]

Same reason; conflicts with user-defined types named Vector

@nevi-me I think this change might be missing our change to the code from idl_gen_java.cpp that does the renaming of Vector to _Vector

[bjornharrtell]

@nevi-me this seems to be causing test failures, do you have possiblity to look at it?

[nevi-me]

@nevi-me this seems to be causing test failures, do you have possiblity to look at it?

I'll take a look today, thanks

[aardappel]

the renaming to _Vector causes a lot of churn, breaks the API, and makes the API uglier.. not sure that's worth it over resolving a possible name clash that we haven't had complaints about so far.

[maxburke]

@aardappel Well, rather than complain about it, we're putting together this PR :) It's not a "possible name clash" for us, it's an actual name clash, and we have deployed code where renaming our Vector type is a really expensive change to make.

What would you suggest as an alternative?

[bjornharrtell]

Why not just fully qualify as with Table?

[aardappel]

"renaming our Vector type is a really expensive change to make" yes, that's just what I said about making the change on the FlatBuffers side. Except it is 1 user (you) vs potentially many FlatBuffers users affected, depending on how this collision gets fixed.

Maybe first lets understand the problem. How is your custom vector type set up in a way that it collides with these FlatBuffers Vector types, and why is that unavoidable? Agree with @bjornharrtell that in theory this should all be solvable with qualifying.

[maxburke]

Maybe first lets understand the problem. How is your custom vector type set up in a way that it collides with these FlatBuffers Vector types, and why is that unavoidable? Agree with @bjornharrtell that in theory this should all be solvable with qualifying.

It's a table type called Vector. While some compilation errors can be resolved with full qualification the one we error we were unable to resolve is that the subclass cannot be named the same as its parent:

[ERROR] /Users/max/src/ul/ulsdk/java/src/main/java/com/urbanlogiq/ulsdk/types/generated/Vector.java:[78,23] class com.urbanlogiq.ulsdk.types.generated.Vector is already defined in package com.urbanlogiq.ulsdk.types.generated

I'm not convinced of rename of Vector.

[jtdavis777]

it seems there is some overlap with this PR and #8581