Replace long if-else with match-case#885
Merged
zxzxwu merged 1 commit intogoogle:mainfrom Feb 11, 2026
Merged
Conversation
4a19e14 to
aa2dfda
Compare
Collaborator
Author
|
Hmmm, actually match-case is sometimes even slightly slower than if-else, but it does provide better readability. Speed: dict (prebuilt) >> |
barbibulle
approved these changes
Feb 10, 2026
Collaborator
barbibulle
left a comment
There was a problem hiding this comment.
This is nice. Readability is more important than raw performance, especially that the difference here isn't very large.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.