Open
Conversation
Contributor
Author
|
Same as #11, if there are multiple apps requiring SDP dicovery, should there be a singleton pattern for SDP?(Though this is probably a Bumble implementation detail) |
zxzxwu
force-pushed
the
sdp
branch
4 times, most recently
from
557765f to
9b7fb91
Compare
uael
reviewed
Sep 26, 2023
| rpc RemoveService(RemoveServiceRequest) returns (google.protobuf.Empty); | ||
| // List all registered SDP services | ||
| rpc ListAttributes(ListAttributesRequest) returns (ListAttributesResponse); | ||
| // Client methods |
Contributor
There was a problem hiding this comment.
I suggest to remove the Connect and Disconnect APIs
Contributor
Author
There was a problem hiding this comment.
It would them be a problem: if there are multiple SDP connections on the same ACL connection, which one it should go?
| // Register an SDP service | ||
| rpc AddService(AddServiceRequest) returns (google.protobuf.Empty); | ||
| // Remove an SDP service | ||
| rpc RemoveService(RemoveServiceRequest) returns (google.protobuf.Empty); |
Contributor
There was a problem hiding this comment.
I would remove the RemoveService API and I'm not even sure we need to AddService as well 🤔
| message ListAttributesRequest {} | ||
|
|
||
| message ListAttributesResponse { | ||
| repeated ServiceAttribute attributes = 1; |
Contributor
There was a problem hiding this comment.
Suggested change
| repeated ServiceAttribute attributes = 1; | |
| map<uint32, repeated ServiceAttribute> attributes = 1; |
| } | ||
|
|
||
| message ServiceAttribute { | ||
| uint32 id = 1; |
| // Remove an SDP service | ||
| rpc RemoveService(RemoveServiceRequest) returns (google.protobuf.Empty); | ||
| // List all registered SDP services | ||
| rpc ListAttributes(ListAttributesRequest) returns (ListAttributesResponse); |
Contributor
Author
There was a problem hiding this comment.
An usage is to avoid handle collision
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feel free to modify