Migrate BooleanChoiceViewHolderFactory, RadioGroupViewHolderFactory, CheckBoxGroupViewHolderFactory to compose #2905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LZRS
force-pushed
the
sdc-compose-boolean-choice
branch
from
0c680a4 to
b832190
Compare
LZRS
force-pushed
the
sdc-compose-boolean-choice
branch
from
4e3050b to
db653e5
Compare
FikriMilano
suggested changes
Nov 26, 2025
| } | ||
| ChoiceOrientationTypes.VERTICAL -> { | ||
| Column( | ||
| modifier = Modifier.fillMaxWidth(), |
Contributor
There was a problem hiding this comment.
Suggested change
| modifier = Modifier.fillMaxWidth(), | |
| modifier = Modifier.selectableGroup().fillMaxWidth(), |
| } | ||
| ChoiceOrientationTypes.VERTICAL -> { | ||
| Column( | ||
| modifier = Modifier.fillMaxWidth(), |
Contributor
There was a problem hiding this comment.
Suggested change
| modifier = Modifier.fillMaxWidth(), | |
| modifier = Modifier.selectableGroup().fillMaxWidth(), |
| import kotlinx.coroutines.launch | ||
| import org.hl7.fhir.r4.model.QuestionnaireResponse | ||
|
|
||
| internal object CheckBoxGroupComposeViewHolderFactory : QuestionnaireItemComposeViewHolderFactory { |
Contributor
There was a problem hiding this comment.
there seems to be 2 factories for checkbox?
github-project-automation
bot
moved this from New
to PR under Review
in Android FHIR SDK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2859
Description
Clear and concise code change description.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.