Updated processor to return only visible surfaces#928
Open
btw17 wants to merge 7 commits intogoogle:mainfrom
Open
Updated processor to return only visible surfaces#928btw17 wants to merge 7 commits intogoogle:mainfrom
btw17 wants to merge 7 commits intogoogle:mainfrom
Conversation
See google#898 for more details.
… method With the base processor filtering surfaces now, this ensures the Angular implementation is consistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, processing
surfaceUpdateprior tobeginRenderingwould result in a surface returning via the message processor'sgetSurfacesmethod that could not be rendered. Now, any surface without arootComponentIdis filtered out.See #898 for more details.
Description
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. For larger changes, raising an issue first helps reduce redundant work.
Pre-launch Checklist
If you need help, consider asking for advice on the discussion board.