Skip to content

Revert Change CallId to allow for more data. (#793) #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jgindin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Revert Change CallId to allow for more data. (#793) #880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions specification/v0_10/json/client_to_server.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,10 @@
"$ref": "common_types.json#/$defs/CallId",
"description": "Unique ID for the instance of this function. MUST be copied verbatim from the function invocation."
},
"call": {
"type": "string",
"description": "The name of the function which was called. MUST be copied verbatim from the function invocation. Useful for logging."
},
Comment on lines +54 to +57
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The new call property is a useful addition for logging. However, the test suite for functionResponse messages in specification/v0_10/test/cases/function_response.json has not been updated to include cases for this new property. Per the repository's style guide, new code changes should be accompanied by tests. Please add a test case for a valid functionResponse containing the call property to ensure it is handled correctly.

References
  1. If there are code changes, code should have tests. (link)

"value": {
"description": "The return value of the function invocation.",
"type": [
Expand Down
15 changes: 2 additions & 13 deletions specification/v0_10/json/common_types.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,19 +9,8 @@
"description": "The unique identifier for a component, used for both definitions and references within the same surface."
},
"CallId": {
"type": "object",
"description": "The unique identifier for a server initiated function call.",
"properties": {
"agentId": {
"type": "string",
"description": "Identifies the agent initiating the function call."
},
"callId": {
"type": "string",
"description": "Uniquely identifies this instance of the function call."
}
},
"required": ["callId"]
"type": "string",
"description": "The unique identifier for a server initiated function call."
},
"AccessibilityAttributes": {
"type": "object",
Expand Down
20 changes: 10 additions & 10 deletions specification/v0_10/test/cases/call_function_message.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"returnType": "void",
"callableFrom": "clientOrRemote"
},
"functionCallId": { "callId": "unique-call-id-123" },
"functionCallId": "unique-call-id-123",
"wantResponse": true
}
},
Expand All @@ -29,7 +29,7 @@
"returnType": "void",
"callableFrom": "remoteOnly"
},
"functionCallId": { "callId": "unique-call-id-123a" },
"functionCallId": "unique-call-id-123a",
"wantResponse": false
}
},
Expand All @@ -46,7 +46,7 @@
"returnType": "void",
"callableFrom": "clientOrRemote"
},
"functionCallId": { "callId": "unique-call-id-124" }
"functionCallId": "unique-call-id-124"
}
},
{
Expand All @@ -67,7 +67,7 @@
"valid": false,
"data": {
"version": "v0.10",
"functionCallId": { "callId": "unique-call-id-125" }
"functionCallId": "unique-call-id-125"
}
},
{
Expand All @@ -81,7 +81,7 @@
"returnType": "boolean",
"callableFrom": "clientOnly"
},
"functionCallId": { "callId": "unique-call-id-126" }
"functionCallId": "unique-call-id-126"
}
},
{
Expand All @@ -94,7 +94,7 @@
"args": { "value": "bar" },
"returnType": "boolean"
},
"functionCallId": { "callId": "unique-call-id-126b" }
"functionCallId": "unique-call-id-126b"
}
},
{
Expand All @@ -110,7 +110,7 @@
"returnType": "boolean",
"callableFrom": "clientOrRemote"
},
"functionCallId": { "callId": "unique-call-id-127" }
"functionCallId": "unique-call-id-127"
}
},
{
Expand All @@ -126,7 +126,7 @@
"returnType": "boolean",
"callableFrom": "clientOrRemote"
},
"functionCallId": { "callId": "unique-call-id-128" }
"functionCallId": "unique-call-id-128"
}
},
{
Expand All @@ -140,7 +140,7 @@
"returnType": "object",
"callableFrom": "clientOrRemote"
},
"functionCallId": { "callId": "unique-call-id-129" }
"functionCallId": "unique-call-id-129"
}
},
{
Expand All @@ -156,7 +156,7 @@
"returnType": "boolean",
"callableFrom": "clientOrRemote"
},
"functionCallId": { "callId": "id-3" }
"functionCallId": "id-3"
}
}
]
Expand Down
4 changes: 2 additions & 2 deletions specification/v0_10/test/cases/client_messages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"version": "v0.10",
"error": {
"code": "FUNCTION_FAILED",
"functionCallId": { "callId": "unique-call-id-132" },
"functionCallId": "unique-call-id-132",
"message": "Something went wrong"
}
}
Expand All @@ -62,7 +62,7 @@
"version": "v0.10",
"error": {
"code": "FUNCTION_FAILED",
"functionCallId": { "callId": "unique-call-id-133" },
"functionCallId": "unique-call-id-133",
"surfaceId": "main",
"message": "Something went wrong"
}
Expand Down
16 changes: 8 additions & 8 deletions specification/v0_10/test/cases/function_response.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"data": {
"version": "v0.10",
"functionResponse": {
"functionCallId": { "callId": "unique-call-id-130" },
"functionCallId": "unique-call-id-130",
"value": {
"result": "success",
"count": 42
Expand All @@ -33,7 +33,7 @@
"data": {
"version": "v0.10",
"functionResponse": {
"functionCallId": { "callId": "unique-call-id-131a" },
"functionCallId": "unique-call-id-131a",
"value": "success"
}
}
Expand All @@ -44,7 +44,7 @@
"data": {
"version": "v0.10",
"functionResponse": {
"functionCallId": { "callId": "unique-call-id-131b" },
"functionCallId": "unique-call-id-131b",
"value": 42
}
}
Expand All @@ -55,7 +55,7 @@
"data": {
"version": "v0.10",
"functionResponse": {
"functionCallId": { "callId": "unique-call-id-131c" },
"functionCallId": "unique-call-id-131c",
"value": true
}
}
Expand All @@ -66,7 +66,7 @@
"data": {
"version": "v0.10",
"functionResponse": {
"functionCallId": { "callId": "unique-call-id-131d" },
"functionCallId": "unique-call-id-131d",
"value": null
}
}
Expand All @@ -77,7 +77,7 @@
"data": {
"version": "v0.10",
"functionResponse": {
"functionCallId": { "callId": "unique-call-id-131e" },
"functionCallId": "unique-call-id-131e",
"value": [
"one",
2,
Expand All @@ -93,7 +93,7 @@
"data": {
"version": "v0.10",
"functionResponse": {
"functionCallId": { "callId": "unique-call-id-131" },
"functionCallId": "unique-call-id-131",
"value": {
"result": { "nested": "object" }
}
Expand All @@ -106,7 +106,7 @@
"data": {
"version": "v0.10",
"functionResponse": {
"functionCallId": { "callId": "unique-call-id-131f" },
"functionCallId": "unique-call-id-131f",
"value": [
"one",
{
Expand Down
Loading