fix(samples): supply --subagent_urls and sub-agent ports in demo:orchestrator#739
Open
retz8 wants to merge 3 commits intogoogle:mainfrom
Open
fix(samples): supply --subagent_urls and sub-agent ports in demo:orchestrator#739retz8 wants to merge 3 commits intogoogle:mainfrom
retz8 wants to merge 3 commits intogoogle:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request fixes the demo:orchestrator script by correctly configuring and launching the orchestrator and its sub-agents. The changes in package.json add the necessary --subagent_urls and set explicit ports for the sub-agents. My review includes a suggestion to refactor the demo:orchestrator script to improve maintainability by reusing existing npm scripts, which will reduce code duplication.
to improve maintainability and reduce code duplication, reuse `serve:agent:*` scripts instead of `cd`. Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes #586.
Changes to
samples/client/lit/package.json:serve:agent:orchestrator: adds the required--subagent_urlsflags (localhost:10003/10004/10005)demo:orchestrator: now starts all five services — shell client, the three sub-agents on explicit ports, andthe orchestrator
Demo
After Running following commands,
terminal shows...
1. Shell Running on 5173
2. Sub-agents running on different ports
3. Orchestrator fetches agents cards from sub agents
4. Orchestrator is now ready and running on 10002
Pre-launch Checklist