Skip to content

fix(samples): supply --subagent_urls and sub-agent ports in demo:orchestrator#739

Open
retz8 wants to merge 3 commits intogoogle:mainfrom
retz8:fix/demo-orchestrator
Open

fix(samples): supply --subagent_urls and sub-agent ports in demo:orchestrator#739
retz8 wants to merge 3 commits intogoogle:mainfrom
retz8:fix/demo-orchestrator

Conversation

@retz8
Copy link
Contributor

@retz8 retz8 commented Mar 1, 2026

Description

This fixes #586.

Changes to samples/client/lit/package.json:

  • serve:agent:orchestrator: adds the required --subagent_urls flags (localhost:10003/10004/10005)
  • demo:orchestrator: now starts all five services — shell client, the three sub-agents on explicit ports, and
    the orchestrator
Service Port Color
Shell client 5173 magenta
restaurant_finder 10003 (overrides default 10002) blue
contact_lookup 10004 green
rizzcharts 10005 (overrides default 10002) yellow
orchestrator 10002 cyan

Demo

After Running following commands,

cd samples/client/lit
export GEMINI_API_KEY="..."
npm install
npm run demo:orchestrator

terminal shows...

1. Shell Running on 5173

shell

2. Sub-agents running on different ports

subagents

3. Orchestrator fetches agents cards from sub agents

rest-card cont-card rizz-card

4. Orchestrator is now ready and running on 10002

orch

Pre-launch Checklist

  • I signed the [CLA].
  • I read the [Contributors Guide].
  • I read the [Style Guide].
  • I have added updates to the [CHANGELOG].
  • I updated/added relevant documentation.
  • My code changes (if any) have tests.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes the demo:orchestrator script by correctly configuring and launching the orchestrator and its sub-agents. The changes in package.json add the necessary --subagent_urls and set explicit ports for the sub-agents. My review includes a suggestion to refactor the demo:orchestrator script to improve maintainability by reusing existing npm scripts, which will reduce code duplication.

to improve maintainability and reduce code duplication, reuse `serve:agent:*` scripts instead of `cd`.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@zeroasterisk
Copy link
Collaborator

@nan-yu after your PR #759 please review this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

demo:orchestrator fails: missing required --subagent_urls argument

2 participants