Add pylint action with Google style configuration.#13
Open
lucasb-eyer wants to merge 1 commit intomainfrom
Open
Add pylint action with Google style configuration.#13lucasb-eyer wants to merge 1 commit intomainfrom
lucasb-eyer wants to merge 1 commit intomainfrom
Conversation
andsteing
requested changes
Aug 9, 2022
Collaborator
andsteing
left a comment
andsteing
left a comment
There was a problem hiding this comment.
I would propose to
- reconfigure to exactly match issues that are also checked internally
- fix all complaints internally
- create PR from updated internal state
- merge this PR
akolesnikoff
force-pushed
the
main
branch
2 times, most recently
from
55f85ef to
430df79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would run pylint with the official Google style configuration on every PR automatically, saving us quite a bit of time.
We can already see results of it in this PR
However, it seems that maybe we should submit the configuration here and fine-tune it a bit? I'm seeing several lint errors that we don't actually hit internally, for example:
So we should see if we like this difference, and/or where it comes from, before merging.