Add unit tests for sampling and text utilities#277
Open
jaisinha77777 wants to merge 1 commit into
Open
Conversation
Adds coverage for concordia/utils/sampling.py (extract_choice_response, dynamically_adjust_temperature) and concordia/utils/text.py (wrap, truncate).
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
@googlebot I signed it! |
Author
|
Hi maintainers, All CI checks, CLA verification, and tests are passing successfully. This PR adds unit test coverage for previously untested utility functions . I would appreciate any feedback or review when convenient. Thanks for your time! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds unit test coverage for two previously untested helper modules:
concordia/utils/sampling.py—extract_choice_response(single-char, trailing paren/period, parenthesized-in-string, and no-match cases) anddynamically_adjust_temperature(below / at / above the attempt midpoint).concordia/utils/text.py—wrap(width handling, newline preservation, empty input) andtruncate(max_length, delimiters, and combined).All 31 tests pass locally via
python -m pytest concordia/utils/sampling_test.py concordia/utils/text_test.py.