Skip to content

fix: sanitize image src in ForumState HTML output #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
uchia6861-tech wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −6
Open

fix: sanitize image src in ForumState HTML output #270

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions concordia/contrib/components/game_master/forum.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,8 +413,11 @@ def _render_post_image(self, post: Post) -> str:
if post.image and post.image.startswith('!['):
src = self._extract_image_src(post.image)
if src:
safe_src = self._escape_html(src)
if not any(src.lower().startswith(scheme) for scheme in ('https://', 'http://', 'data:image/')):
return ''
return (
f'<div class="post-image"><img src="{src}" alt="post image"></div>'
f'<div class="post-image"><img src="{safe_src}" alt="post image"></div>'
)
return ''

Expand Down Expand Up @@ -442,11 +445,13 @@ def to_html(self, title: str = '') -> str:
reply_image_html = ''
reply_image = reply.get('image')
if reply_image and reply_image.startswith('!['):
reply_image_html = (
'<div class="post-image"><img src="'
f'{self._extract_image_src(reply_image)}"'
' alt="reply image"></div>'
)
reply_src = self._extract_image_src(reply_image)
if any(reply_src.lower().startswith(scheme) for scheme in ('https://', 'http://', 'data:image/')):
reply_image_html = (
'<div class="post-image"><img src="'
f'{self._escape_html(reply_src)}"'
' alt="reply image"></div>'
)
replies_html += f"""
<div class="reply">
<div class="reply-meta">
Expand Down