Increase contrib/components test coverage (marketplace, day_in_the_life_initializer, death, situation_representation, spaceship_system)

[NandiniDhanrale]

Summary

• Add focused unit tests for contrib/components modules with low or missing coverage:
  • agent/choice_of_component.py
  • agent/situation_representation_via_narrative.py
  • game_master/spaceship_system.py
  • game_master/death.py
  • game_master/marketplace.py
  • game_master/day_in_the_life_initializer.py
• Add a scoped test compatibility shim in contrib/components/conftest.py for Python 3.11 (typing.override).
• No production code behavior changes; test-only additions.

Coverage impact (focused modules)

• situation_representation_via_narrative.py: 100%
• spaceship_system.py: 93%
• death.py: 94%
• day_in_the_life_initializer.py: 89%
• marketplace.py: 81%
• choice_of_component.py: 95%
• Combined focused scan across these modules: 88%

Validation

• pytest -n 0 concordia/contrib/components/agent/choice_of_component_test.py concordia/contrib/components/agent/situation_representation_via_narrative_test.py concordia/contrib/components/game_master/spaceship_system_test.py concordia/contrib/components/game_master/death_test.py concordia/contrib/components/game_master/marketplace_test.py concordia/contrib/components/game_master/day_in_the_life_initializer_test.py
• pytest concordia/contrib/components/agent/choice_of_component_test.py concordia/contrib/components/agent/situation_representation_via_narrative_test.py concordia/contrib/components/game_master/spaceship_system_test.py concordia/contrib/components/game_master/death_test.py concordia/contrib/components/game_master/marketplace_test.py concordia/contrib/components/game_master/day_in_the_life_initializer_test.py

Part of #205

[NandiniDhanrale]

Follow-up fix for failing checks:

• Updated callable usage in examples/games/haggling/haggling.py, examples/games/haggling_multi_item/haggling_multi_item.py, and examples/games/pub_coordination/pub_coordination.py.
• These files previously imported language_model_setup as a function but called it like a module attribute; they now call the function directly.

Validation:

• Ran pytype --pythonpath=. examples in the project venv.
• Result: success, no errors reported.

Note:

• Installed pytype and sentence-transformers into the local venv to reproduce the check path and verify the fix end-to-end.

[NandiniDhanrale]

Addressed the E1102 not-callable failure from examples/games/haggling/haggling.py.

• Switched example entrypoints to call language_model_setup via the concordia.contrib.language_models module (language_model_utils.language_model_setup(...)).
• Applied consistently in:
  • examples/games/haggling/haggling.py
  • examples/games/haggling_multi_item/haggling_multi_item.py
  • examples/games/pub_coordination/pub_coordination.py

Local validation:

• pytype --pythonpath=. examples → success, no errors found.
• python -m pylint examples/games/haggling/haggling.py -E → no errors.

[NandiniDhanrale]

The test-concordia pull_request job failed in the Typecheck Concordia step. Local focused tests and the targeted pytype check for situation_representation_via_narrative are green. Could a maintainer please rerun the failed workflow job when convenient?

[NandiniDhanrale]

Validation update

Aligned with the current scope, I'm stopping here—no wider sweep.

• Fixed the type-check issue in concordia/contrib/components/agent/situation_representation_via_narrative_test.py by passing a properly typed logging_channel callable and updating assertions to validate captured payloads.
• Focused regression for contrib/components/agent (currently choice_of_component_test.py and situation_representation_via_narrative_test.py) is green: 5 passed, 0 failed.
• pytype on concordia/contrib/components/agent/situation_representation_via_narrative_test.py is green: Success: no errors found.