feat: add modernize analyzer suite #6126
Conversation
ldez
force-pushed
the
feat/modernize
branch
2 times, most recently
from
6067bf6 to
b9b3d11
Compare
There was a problem hiding this comment.
Dang, that's a lot of test cases, nice! ⭐
I noticed there's 100 comments saying nope and 24 saying noop (x2 for the fixed version). Is this intentional? I guess noop would make more sense since there's no operation from any analyzer in those scenarios.
Also super nit, but there's a mix between Nope., nope: and nope, prefixed lines where we don't expect any diagnostic.
Of course, none of this is something I would block on and the clarification to why they don't have any diagnostic is what matters!
|
The test files are from |
| - '^math\.' | ||
| - '^http\.StatusText$' | ||
|
|
||
| modernize: |
There was a problem hiding this comment.
Great to finally see this in here! 🚀 What are the default values for this linter?
There was a problem hiding this comment.
The default values are all modernize analyzers.
4 participants
Related to #6123
Related to #686