Skip to content

testing: respect -parallel when t.Run is called concurrently - #80562

Open
harjothkhara wants to merge 1 commit into
golang:masterfrom
harjothkhara:fix-64470-parallel-limit
Open

testing: respect -parallel when t.Run is called concurrently#80562
harjothkhara wants to merge 1 commit into
golang:masterfrom
harjothkhara:fix-64470-parallel-limit

Conversation

@harjothkhara

Copy link
Copy Markdown
Contributor

When t.Run is called concurrently from several goroutines, the
sequential subtests it starts all share one running slot. Each of them
released that slot to make room for its own parallel subtests, so with
N concurrent callers the slot was released N times and up to N parallel
tests ran at once, exceeding -parallel.

Release the shared slot at most once, using a flag on the test that
owns it, and let only that subtest reacquire it. Serve a reacquiring
test after all tests waiting to start in parallel, so it cannot take a
slot from a parallel test that is still waiting.

Fixes #64470.

When t.Run is called concurrently from several goroutines, the
sequential subtests it starts all share one running slot. Each of them
released that slot to make room for its own parallel subtests, so with
N concurrent callers the slot was released N times and up to N parallel
tests ran at once, exceeding -parallel.

Release the shared slot at most once, using a flag on the test that
owns it, and let only that subtest reacquire it. Serve a reacquiring
test after all tests waiting to start in parallel, so it cannot take a
slot from a parallel test that is still waiting.

Fixes golang#64470.

Change-Id: I5e1774d87327b40442a6a9908dc39f63de05c942
@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: a3b8fc9) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/805160.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

testing: parallel tests exceed -test.parallel flag if T.Run is called from multiple goroutines

2 participants