Skip to content

runtime: remove stackcheck from openbsd/riscv64 - #80553

Open
mauri870 wants to merge 1 commit into
golang:masterfrom
mauri870:revert-openbsd-riscv64
Open

runtime: remove stackcheck from openbsd/riscv64#80553
mauri870 wants to merge 1 commit into
golang:masterfrom
mauri870:revert-openbsd-riscv64

Conversation

@mauri870

Copy link
Copy Markdown
Member

CL 541735 added runtime·stackcheck to mstart_stub on openbsd/riscv64,
but on OpenBSD (and any other platform backed by OS-allocated stacks)
mp.g0.stack.hi and mp.g0.stack.lo are both zero at that point. As a
result the port is currently broken.

No other OpenBSD architecture currently calls stackcheck.

CL 541735 added runtime·stackcheck to mstart_stub on openbsd/riscv64,
but on OpenBSD (and any other platform backed by OS-allocated stacks)
mp.g0.stack.hi and mp.g0.stack.lo are both zero at that point. As a
result the port is currently broken.

No other OpenBSD architecture currently calls stackcheck.
@mauri870 mauri870 self-assigned this Jul 23, 2026
@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: 87db194) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/804961.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/804961.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Mauri de Souza Meneguzzo:

Patch Set 1: Commit-Queue+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/804961.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2026-07-23T19:16:31Z","revision":"49a30a793d59270ae400eb84572e60976d50f4a1"}


Please don’t reply on this GitHub thread. Visit golang.org/cl/804961.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Mauri de Souza Meneguzzo:

Patch Set 1: -Commit-Queue

(Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_63983>)


Please don’t reply on this GitHub thread. Visit golang.org/cl/804961.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 1:

This CL has passed the run


Please don’t reply on this GitHub thread. Visit golang.org/cl/804961.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 1: LUCI-TryBot-Result+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/804961.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Joel Sing:

Patch Set 1: Code-Review+2

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/804961.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Keith Randall:

Patch Set 1: Code-Review+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/804961.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants