-
Notifications
You must be signed in to change notification settings - Fork 18.4k
reflect: add iterator equivalents for NumField, NumIn, NumOut and NumMethod #75646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: 6c6e78c) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/707356. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/707356. |
Message from Sean Liao: Patch Set 1: Hold+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/707356. |
Message from Sean Liao: Patch Set 1: -Hold Commit-Queue+1 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/707356. |
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-09-28T23:16:57Z","revision":"c3100f6d710471d83bba35e191cede437449b31d"} Please don’t reply on this GitHub thread. Visit golang.org/cl/707356. |
Message from Jorropo: Patch Set 1: Commit-Queue+1 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/707356. |
Message from Jorropo: Patch Set 1: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/707356. |
Message from Sean Liao: Patch Set 1: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/707356. |
Message from Go LUCI: Patch Set 1: This CL has failed the run. Reason: Tryjob golang/try/gotip-linux-amd64_avx512 has failed with summary (view all results):
To reproduce, try Additional links for debugging: Please don’t reply on this GitHub thread. Visit golang.org/cl/707356. |
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/707356. |
Message from Sean Liao: Patch Set 1: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/707356. |
d6755b6
to
6b5ba32
Compare
This PR (HEAD: 6b5ba32) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/707356. Important tips:
|
Message from Quentin Quaadgras: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/707356. |
Message from Quentin Quaadgras: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/707356. |
Message from Quentin Quaadgras: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/707356. |
Message from Quentin Quaadgras: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/707356. |
Message from Quentin Quaadgras: Patch Set 3: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/707356. |
Message from Jorropo: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/707356. |
Message from Jorropo: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/707356. |
Message from Quentin Quaadgras: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/707356. |
Message from Jorropo: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/707356. |
This PR (HEAD: d17a28a) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/707356. Important tips:
|
Message from Alan Donovan: Patch Set 4: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/707356. |
Message from Quentin Quaadgras: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/707356. |
Message from Alan Donovan: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/707356. |
Message from Quentin Quaadgras: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/707356. |
This PR (HEAD: 38b1a42) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/707356. Important tips:
|
Message from Quentin Quaadgras: Patch Set 5: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/707356. |
Message from Alan Donovan: Patch Set 5: Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/707356. |
This PR (HEAD: f29b7a2) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/707356. Important tips:
|
Message from Quentin Quaadgras: Patch Set 6: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/707356. |
Message from Alan Donovan: Patch Set 6: Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/707356. |
Message from Alan Donovan: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/707356. |
…Method The new methods are Type.Fields, Type.Methods, Type.Ins, Type.Outs, Value.Fields and Value.Methods. These methods have been introduced into the reflect package (as well as tests) replacing any three-clause for loops where possible. Fixes golang#66631
This PR (HEAD: 5bf50a0) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/707356. Important tips:
|
Message from Alan Donovan: Patch Set 7: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/707356. |
The new methods are Type.Fields, Type.Methods, Type.Ins, Type.Outs,
Value.Fields and Value.Methods.
These methods have been introduced into the reflect package (as well
as tests) replacing three-clause for loops where possible.
Fixes #66631