include view templates in builds - #13
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request migrates both the main and admin template and static file loading to use Go's
embed.FSfor embedding files into the binary, replacing all filesystem access with embedded resources. This improves deployment simplicity and reliability, as all required assets are now part of the compiled application. Additionally, tests are added to ensure templates are correctly loaded from the embedded filesystem.Template and static file embedding:
embed.FSvariables (TemplateFiles,StaticFiles, andViewFiles) togojang/views/templates.goandgojang/admin/admin_renderer.goto embed templates and static files into the binary. [1] [2]gojang/views/renderers/renderer.goandgojang/admin/admin_renderer.goto read from embedded files instead of disk, usingfs.WalkDirandReadFile. [1] [2] [3] [4] [5] [6]gojang/cmd/web/main.goto use embedded filesystems for both main and admin static assets, replacinghttp.Dirwithhttp.FS.Testing:
gojang/views/renderers/renderer_test.goandgojang/admin/admin_renderer_test.goto verify that templates are loaded from the embedded filesystem and that partials are included as expected. [1] [2]Code cleanup:
os,filepath) in renderer files. [1] [2]These changes make the application fully self-contained with respect to templates and static assets, improving portability and reducing deployment errors.