Skip to content

Conversation

@TheDying0fLight
Copy link
Contributor

When closing a tab while not at the end of the history all entries after the current idx are deleted. This PRs goal is to ensure that the rest of the history is kept.

Note: There currently is an issue with the history when working with script files (see #113619). So I only used files from the internal documentation for testing this

Example

------- history -----
0 :  AABB
1 :  float <--- this is closed
2 :  ClassDB
3 :  bool
curr idx:  1

Closing 1: float

Without PR

------- history -----
0 :  AABB
curr idx:  0

With PR

------- history -----
0 :  AABB
1 :  ClassDB
2 :  bool
curr idx:  0

@TheDying0fLight TheDying0fLight requested a review from a team as a code owner December 10, 2025 17:27
@TheDying0fLight TheDying0fLight changed the title Keep tail of ScriptEditor tab history when closing tab Keep end of ScriptEditor tab history when closing tab Dec 10, 2025
@kitbdev kitbdev added this to the 4.6 milestone Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants