Skip to content

Adjust license text according to main repository#12116

Open
notroid5 wants to merge 2 commits into
godotengine:masterfrom
notroid5:patch-1
Open

Adjust license text according to main repository#12116
notroid5 wants to merge 2 commits into
godotengine:masterfrom
notroid5:patch-1

Conversation

@notroid5

Copy link
Copy Markdown
Contributor

@notroid5
notroid5 requested a review from a team as a code owner June 30, 2026 04:09
@notroid5

notroid5 commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

After reading again, should the warning at the top not say: "The recommendations on this page"?

Edit: Maybe also change "under this same license" at the start to either "under the same license" or "under this license"? Both "this" and "same" refer to the previously mentioned MIT License, so it feels redundant.

@Calinou Calinou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense, but since AUTHORS.md isn't distributed alongside with the game, how can people know which AUTHORS.md file it's referring to?

In godotengine/godot#51028, I addressed this by replacing (see AUTHORS.md) with (see --about authors command line argument).

I think it should be replaced with a full URL to the file in this particular instance.

Comment thread about/complying_with_licenses.rst Outdated
Co-authored-by: Hugo Locurcio <hugo.locurcio@hugo.pro>

@Calinou Calinou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@skyace65 skyace65 added the area:about Issues and PRs related to the About section of the documentation and other general articles label Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:about Issues and PRs related to the About section of the documentation and other general articles enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants