Fix redirects in Safari #11342
Merged
Fix redirects in Safari #11342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivorforce
added
bug
enhancement
content:website
…4 page instead of checking if we're on 404 via the API.
Ivorforce
force-pushed
the
404-redirect-safari
branch
from
b5aed24 to
2d9c236
Compare
mhilbrunner
approved these changes
Oct 5, 2025
Member
mhilbrunner
left a comment
mhilbrunner
left a comment
There was a problem hiding this comment.
Makes sense and LGTM, giving Calinou final approval.
Member
|
cc @Calinou |
Member
|
Thank you! Merged. |
Member
|
Cherrypicked to 4.5 in #11448. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redirects currently don't work in Safari. The reason is that
window.performance.getEntries()[0].responseStatusis unsupported.Instead of checking in js whether we're 404-ing, I moved the script into the 404 page. This has the additional benefit that it is not loaded / run on any other pages except those that 404.
I tested the redirect (in Safari and Chrome) by changing
fetch("/en/latest/_static/redirects.csv")intofetch("/_static/redirects.csv"),inserting/404.html,/engine_details/file_formats/gdscript_grammar.htmlintoredirects.csv, and openinglocalhost:8001/404.html.