Skip to content

fix: resolve fallow unresolved imports - #1452

Open
kbader-godaddy wants to merge 4 commits into
nextfrom
fix/fallow-unresolved-imports
Open

fix: resolve fallow unresolved imports#1452
kbader-godaddy wants to merge 4 commits into
nextfrom
fix/fallow-unresolved-imports

Conversation

@kbader-godaddy

@kbader-godaddy kbader-godaddy commented Jun 18, 2026

Copy link
Copy Markdown
Contributor
  • Fix 58+ fallow unresolved import findings by correcting JSDoc @type import specifiers from .js to .d.ts
  • Add **/template/** and index.html to fallow ignorePatterns (false positives from scaffold templates and deleted docsify plugin)
  • Add /path/to/app/** to ignoreUnresolvedImports (fake paths in swagger test mocks)
  • Remove unnecessary comments and @param/@returns from JS files
  • Add missing types to internal.d.ts for validateOptions, handleTemplate, runScript, lookupIndex

Copilot AI review requested due to automatic review settings June 18, 2026 16:38
@kbader-godaddy
kbader-godaddy requested a review from a team as a code owner June 18, 2026 16:38
@changeset-bot

changeset-bot Bot commented Jun 18, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 04d3f2d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

Copy link
Copy Markdown
Contributor

Fallow audit report

No GitHub PR/MR findings.

Generated by fallow.

@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

🌱 Fallow Health: 🟢 B · 77.7 / 100

What is costing points, repo-wide:

Check Penalty
Unit size −10.0
Duplication −9.6
Coupling −1.1
Circular dependencies −0.9
Dead exports −0.4
Maintainability −0.3

Repo-wide score for trend visibility — not a merge gate. Watch the grade climb as PRs clean up touched files. Updated each push (04d3f2d).

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reduces fallow “unresolved imports” findings across the repo by updating JSDoc import() type specifiers to point at existing .d.ts files, extending .fallowrc.json ignores for known false-positives, and adding a few missing internal type declarations for create-gasket-app.

Changes:

  • Update JSDoc @type {import(...).X} references from *.js to *.d.ts across multiple packages to match where the types actually live.
  • Extend .fallowrc.json to ignore template scaffolds, index.html, and mock “fake path” references.
  • Add missing type declarations (validateOptions, handleTemplate, runScript) to packages/create-gasket-app/lib/internal.d.ts.

Reviewed changes

Copilot reviewed 24 out of 27 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/gasket-plugin-command/lib/index.d.ts Point internal type imports at the actual declaration file.
packages/gasket-nextjs/lib/document/index.js Fix JSDoc type import path and simplify doc blocks.
packages/create-gasket-app/lib/utils/process-options.js Update JSDoc imports to reference internal.d.ts.
packages/create-gasket-app/lib/utils/process-command.js Update JSDoc imports to reference internal.d.ts.
packages/create-gasket-app/lib/utils/process-args.js Update JSDoc imports to reference internal.d.ts.
packages/create-gasket-app/lib/utils/create-option.js Update JSDoc imports to reference internal.d.ts.
packages/create-gasket-app/lib/scaffold/with-spinner.js Update JSDoc imports to reference internal.d.ts.
packages/create-gasket-app/lib/scaffold/utils.js Update JSDoc imports to reference internal.d.ts.
packages/create-gasket-app/lib/scaffold/dump-error-context.js Update JSDoc imports to reference internal.d.ts.
packages/create-gasket-app/lib/scaffold/create-context.js Update JSDoc imports to reference internal.d.ts / index.d.ts.
packages/create-gasket-app/lib/scaffold/actions/write-pkg.js Update JSDoc imports to reference internal.d.ts.
packages/create-gasket-app/lib/scaffold/actions/write-gasket-config.js Update JSDoc imports to reference internal.d.ts and tweak inline commentary.
packages/create-gasket-app/lib/scaffold/actions/setup-pkg.js Update JSDoc imports to reference internal.d.ts.
packages/create-gasket-app/lib/scaffold/actions/prompt-hooks.js Update JSDoc imports to reference internal.d.ts.
packages/create-gasket-app/lib/scaffold/actions/print-report.js Update JSDoc imports to reference internal.d.ts and trim doc blocks.
packages/create-gasket-app/lib/scaffold/actions/post-create-hooks.js Update JSDoc imports to reference internal.d.ts and type runScript.
packages/create-gasket-app/lib/scaffold/actions/mkdir.js Update JSDoc imports to reference internal.d.ts.
packages/create-gasket-app/lib/scaffold/actions/link-modules.js Update JSDoc imports to reference internal.d.ts.
packages/create-gasket-app/lib/scaffold/actions/install-modules.js Update JSDoc imports to reference internal.d.ts.
packages/create-gasket-app/lib/scaffold/actions/global-prompts.js Update JSDoc imports to reference internal.d.ts.
packages/create-gasket-app/lib/scaffold/actions/git-init.js Fix incorrect JSDoc type import extension to internal.d.ts.
packages/create-gasket-app/lib/scaffold/actions/generate-files.js Update JSDoc imports to reference internal.d.ts and adjust doc text.
packages/create-gasket-app/lib/scaffold/actions/create-hooks.js Update JSDoc imports to reference internal.d.ts.
packages/create-gasket-app/lib/internal.d.ts Add missing internal type declarations used by updated JSDoc.
packages/create-gasket-app/lib/commands/create.js Switch JSDoc typing to internal.d.ts / index.d.ts and remove param/return tags per conventions.
.fallowrc.json Add ignore patterns and unresolved-import ignore entries to reduce false positives.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/create-gasket-app/lib/scaffold/actions/generate-files.js
@kbader-godaddy kbader-godaddy self-assigned this Jun 18, 2026
Copilot AI review requested due to automatic review settings June 18, 2026 17:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 27 out of 30 changed files in this pull request and generated 2 comments.

Comment thread packages/create-gasket-app/lib/commands/create.js
Comment thread packages/create-gasket-app/lib/scaffold/actions/generate-files.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants