fix: resolve fallow unresolved imports - #1452
Conversation
|
Fallow audit reportNo GitHub PR/MR findings. Generated by fallow. |
🌱 Fallow Health: 🟢 B · 77.7 / 100What is costing points, repo-wide:
Repo-wide score for trend visibility — not a merge gate. Watch the grade climb as PRs clean up touched files. Updated each push ( |
There was a problem hiding this comment.
Pull request overview
This PR reduces fallow “unresolved imports” findings across the repo by updating JSDoc import() type specifiers to point at existing .d.ts files, extending .fallowrc.json ignores for known false-positives, and adding a few missing internal type declarations for create-gasket-app.
Changes:
- Update JSDoc
@type {import(...).X}references from*.jsto*.d.tsacross multiple packages to match where the types actually live. - Extend
.fallowrc.jsonto ignore template scaffolds,index.html, and mock “fake path” references. - Add missing type declarations (
validateOptions,handleTemplate,runScript) topackages/create-gasket-app/lib/internal.d.ts.
Reviewed changes
Copilot reviewed 24 out of 27 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/gasket-plugin-command/lib/index.d.ts | Point internal type imports at the actual declaration file. |
| packages/gasket-nextjs/lib/document/index.js | Fix JSDoc type import path and simplify doc blocks. |
| packages/create-gasket-app/lib/utils/process-options.js | Update JSDoc imports to reference internal.d.ts. |
| packages/create-gasket-app/lib/utils/process-command.js | Update JSDoc imports to reference internal.d.ts. |
| packages/create-gasket-app/lib/utils/process-args.js | Update JSDoc imports to reference internal.d.ts. |
| packages/create-gasket-app/lib/utils/create-option.js | Update JSDoc imports to reference internal.d.ts. |
| packages/create-gasket-app/lib/scaffold/with-spinner.js | Update JSDoc imports to reference internal.d.ts. |
| packages/create-gasket-app/lib/scaffold/utils.js | Update JSDoc imports to reference internal.d.ts. |
| packages/create-gasket-app/lib/scaffold/dump-error-context.js | Update JSDoc imports to reference internal.d.ts. |
| packages/create-gasket-app/lib/scaffold/create-context.js | Update JSDoc imports to reference internal.d.ts / index.d.ts. |
| packages/create-gasket-app/lib/scaffold/actions/write-pkg.js | Update JSDoc imports to reference internal.d.ts. |
| packages/create-gasket-app/lib/scaffold/actions/write-gasket-config.js | Update JSDoc imports to reference internal.d.ts and tweak inline commentary. |
| packages/create-gasket-app/lib/scaffold/actions/setup-pkg.js | Update JSDoc imports to reference internal.d.ts. |
| packages/create-gasket-app/lib/scaffold/actions/prompt-hooks.js | Update JSDoc imports to reference internal.d.ts. |
| packages/create-gasket-app/lib/scaffold/actions/print-report.js | Update JSDoc imports to reference internal.d.ts and trim doc blocks. |
| packages/create-gasket-app/lib/scaffold/actions/post-create-hooks.js | Update JSDoc imports to reference internal.d.ts and type runScript. |
| packages/create-gasket-app/lib/scaffold/actions/mkdir.js | Update JSDoc imports to reference internal.d.ts. |
| packages/create-gasket-app/lib/scaffold/actions/link-modules.js | Update JSDoc imports to reference internal.d.ts. |
| packages/create-gasket-app/lib/scaffold/actions/install-modules.js | Update JSDoc imports to reference internal.d.ts. |
| packages/create-gasket-app/lib/scaffold/actions/global-prompts.js | Update JSDoc imports to reference internal.d.ts. |
| packages/create-gasket-app/lib/scaffold/actions/git-init.js | Fix incorrect JSDoc type import extension to internal.d.ts. |
| packages/create-gasket-app/lib/scaffold/actions/generate-files.js | Update JSDoc imports to reference internal.d.ts and adjust doc text. |
| packages/create-gasket-app/lib/scaffold/actions/create-hooks.js | Update JSDoc imports to reference internal.d.ts. |
| packages/create-gasket-app/lib/internal.d.ts | Add missing internal type declarations used by updated JSDoc. |
| packages/create-gasket-app/lib/commands/create.js | Switch JSDoc typing to internal.d.ts / index.d.ts and remove param/return tags per conventions. |
| .fallowrc.json | Add ignore patterns and unresolved-import ignore entries to reduce false positives. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
@typeimport specifiers from.jsto.d.ts**/template/**andindex.htmlto fallow ignorePatterns (false positives from scaffold templates and deleted docsify plugin)/path/to/app/**to ignoreUnresolvedImports (fake paths in swagger test mocks)@param/@returnsfrom JS filesinternal.d.tsforvalidateOptions,handleTemplate,runScript,lookupIndex