Switch to widen which doesn't require leq on arguments - #2081
Draft
sim642 wants to merge 5 commits into
Draft
Conversation
sim642
added
cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arguments for this approach are given here: https://link.springer.com/chapter/10.1007/978-981-19-9601-6_4.
This currently just pushes the
joindown into the domains, so it currently doesn't achieve much.The goal would be to avoid all such intermediate
joins when they're actually not needed and only have the necessary ones in "leaf" domains.This should improve performance on large programs like rsync: #1967 (comment).
TODO
widen_with_fctsmart_widen