Feat: uds_exists validator #1482
Open
+150
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barash-asenov
changed the title
barash-asenov
force-pushed
the
bux-unix-addr-is-useless
branch
2 times, most recently
from
89dc794 to
94e0bfc
Compare
barash-asenov
force-pushed
the
bux-unix-addr-is-useless
branch
from
94e0bfc to
4b86d5b
Compare
zemzale
approved these changes
Dec 4, 2025
Member
zemzale
left a comment
zemzale
left a comment
There was a problem hiding this comment.
I would like the tests to be cleaner, but otherwise looks good
Comment on lines
+2962
to
+3022
| errs := validate.Var("", "uds_exists") | ||
| NotEqual(t, errs, nil) | ||
| AssertError(t, errs, "", "", "", "", "uds_exists") | ||
|
|
||
| errs = validate.Var("/tmp/nonexistent.sock", "uds_exists") | ||
| NotEqual(t, errs, nil) | ||
| AssertError(t, errs, "", "", "", "", "uds_exists") | ||
|
|
||
| sockPath := "/tmp/test_validator.sock" | ||
| var lc net.ListenConfig | ||
| listener, err := lc.Listen(t.Context(), "unix", sockPath) | ||
| if err != nil { | ||
| t.Fatalf("Failed to create test socket: %v", err) | ||
| } | ||
| defer func() { | ||
| _ = listener.Close() | ||
| }() | ||
| defer func() { | ||
| _ = os.Remove(sockPath) | ||
| }() | ||
| errs = validate.Var(sockPath, "uds_exists") | ||
| Equal(t, errs, nil) | ||
|
|
||
| regularFile := "/tmp/test_validator_regular.txt" | ||
| if err := os.WriteFile(regularFile, []byte("test"), 0644); err != nil { | ||
| t.Fatalf("Failed to create regular file: %v", err) | ||
| } | ||
| defer func() { | ||
| _ = os.Remove(regularFile) | ||
| }() | ||
| errs = validate.Var(regularFile, "uds_exists") | ||
| NotEqual(t, errs, nil) | ||
| AssertError(t, errs, "", "", "", "", "uds_exists") | ||
|
|
||
| dirPath := "/tmp/test_validator_dir" | ||
| if err := os.Mkdir(dirPath, 0755); err != nil && !os.IsExist(err) { | ||
| t.Fatalf("Failed to create directory: %v", err) | ||
| } | ||
| defer func() { | ||
| _ = os.RemoveAll(dirPath) | ||
| }() | ||
| errs = validate.Var(dirPath, "uds_exists") | ||
| NotEqual(t, errs, nil) | ||
| AssertError(t, errs, "", "", "", "", "uds_exists") | ||
|
|
||
| if runtime.GOOS == "linux" { | ||
| abstractSockName := "@test_abstract_socket_" + fmt.Sprintf("%d", time.Now().UnixNano()) | ||
| var lc net.ListenConfig | ||
| abstractListener, err := lc.Listen(t.Context(), "unix", "\x00"+abstractSockName[1:]) | ||
| if err != nil { | ||
| t.Fatalf("Failed to create abstract socket: %v", err) | ||
| } | ||
| defer func() { | ||
| _ = abstractListener.Close() | ||
| }() | ||
| errs = validate.Var(abstractSockName, "uds_exists") | ||
| Equal(t, errs, nil) | ||
| errs = validate.Var("@nonexistent_abstract_socket", "uds_exists") | ||
| NotEqual(t, errs, nil) | ||
| AssertError(t, errs, "", "", "", "", "uds_exists") | ||
| } |
Member
There was a problem hiding this comment.
Only issue I have here, is that I would want the tests to be split up and ran as sub tests.
t.Run("non_existant", func(t *testing.T) {
errs = validate.Var("/tmp/nonexistent.sock", "uds_exists")
NotEqual(t, errs, nil)
AssertError(t, errs, "", "", "", "", "uds_exists")
})Otherwise with all the defer and other things feel hard to read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Or Enhances
Make sure that you've checked the boxes below before you submit PR:
@go-playground/validator-maintainers
As discussed in: #1348