Skip to content

Conversation

ita004
Copy link
Contributor

@ita004 ita004 commented Oct 4, 2025

Description:

Implements reliable auto-expand and auto-scroll behavior for the Actions logs view.

  • Expands running or unfinished steps automatically.
  • Smoothly scrolls to the latest log line during execution.
  • Controlled via existing “Always auto-scroll” and “Expand running steps” options.

Fixes #35570.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 4, 2025
@silverwind
Copy link
Member

Hmm is there no other way than MutationObserver? Isn't the class change that it's observing triggered by our JS?

@ita004 ita004 force-pushed the feature/actions-auto-expand branch from c6a8e9d to 3090f46 Compare October 4, 2025 08:24
@ita004
Copy link
Contributor Author

ita004 commented Oct 4, 2025

Hmm is there no other way than MutationObserver? Isn't the class change that it's observing triggered by our JS?

thanks for the suggestion...have removed the MutationObserver entirely, the auto-expand behavior is now handled directly within loadJob() based on state changes...simplifying the logic and keeping it consistent with the rest of the component’s approach...

@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Oct 4, 2025
@wxiaoguang
Copy link
Contributor

Made some improvements, and you can test the behavior by http://localhost:3000/devtest/repo-action-view/

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 4, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 4, 2025
@wxiaoguang wxiaoguang merged commit 0a0baeb into go-gitea:main Oct 5, 2025
26 checks passed
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Oct 5, 2025
…o-gitea#35583)

Implements reliable auto-expand and auto-scroll behavior for the Actions
logs view.

* Expands running or unfinished steps automatically.
* Smoothly scrolls to the latest log line during execution.
* Controlled via existing “Always auto-scroll” and “Expand running
steps” options.

Fixes go-gitea#35570.

---------

Co-authored-by: wxiaoguang <[email protected]>
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Oct 5, 2025
wxiaoguang added a commit that referenced this pull request Oct 5, 2025
Backport #35583 by ita004

Co-authored-by: Shafi Ahmed <[email protected]>
Co-authored-by: wxiaoguang <[email protected]>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 5, 2025
* giteaofficial/main:
  fix: auto-expand and auto-scroll for actions logs (go-gitea#35570) (go-gitea#35583)
  [skip ci] Updated translations via Crowdin
  [skip ci] Updated translations via Crowdin
  Fix creating pull request failure when the target branch name is the same as some tag (go-gitea#35552)
  Use bundled version of spectral (go-gitea#35573)
  Add rebase push display wrong comments bug (go-gitea#35560)
  Address some CodeQL security concerns (go-gitea#35572)
  fix(webhook): prevent tag events from bypassing branch filters targets go-gitea#35449 (go-gitea#35567)
  Added button to copy file name in PR files (go-gitea#35509)
  Update JS and PY deps (go-gitea#35565)
  Enable a few more tsconfig options (go-gitea#35553)
  Bump github.com/wneessen/go-mail from 0.6.2 to 0.7.1 (go-gitea#35557)
  add more routes to the "expensive" list (go-gitea#35547)
  Drop json-iterator dependency (go-gitea#35544)
  Add proper error message if session provider can not be created (go-gitea#35520)
  use experimental go json v2 library (go-gitea#35392)
  Use global lock instead of status pool for cron lock (go-gitea#35507)
  Move some functions to gitrepo package (go-gitea#35503)
  Move GetDiverging functions to gitrepo (go-gitea#35524)
  [skip ci] Updated translations via Crowdin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/done All backports for this PR have been created backport/v1.25 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend modifies/go Pull requests that update Go code type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Actions logs auto-scroll/auto-expand not working
5 participants