Skip to content

Move some functions to gitrepo package #35543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Move some functions to gitrepo package #35543

wants to merge 19 commits into from
+1,116 −917

Conversation

lunny
Copy link
Member

@lunny lunny commented Sep 28, 2025 •
edited
Loading

Refactor Git command functions to use WithXXX methods instead of exposing RunOpts.
This change simplifies reuse across gitrepo and improves consistency, encapsulation, and maintainability of command options.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Sep 28, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 28, 2025
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin labels Sep 28, 2025
wxiaoguang
wxiaoguang reviewed Sep 28, 2025
View reviewed changes
wxiaoguang
wxiaoguang reviewed Sep 28, 2025
View reviewed changes
@lunny lunny marked this pull request as ready for review September 29, 2025 19:10
@lunny lunny added this to the 1.26.0 milestone Sep 29, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 4, 2025
wxiaoguang
wxiaoguang reviewed Oct 5, 2025
View reviewed changes
wxiaoguang
wxiaoguang reviewed Oct 5, 2025
View reviewed changes
wxiaoguang
wxiaoguang reviewed Oct 5, 2025
View reviewed changes
wxiaoguang
wxiaoguang reviewed Oct 5, 2025
View reviewed changes
wxiaoguang
wxiaoguang reviewed Oct 5, 2025
View reviewed changes
wxiaoguang
wxiaoguang reviewed Oct 5, 2025
View reviewed changes
wxiaoguang
wxiaoguang reviewed Oct 5, 2025
View reviewed changes
@wxiaoguang wxiaoguang force-pushed the lunny/refactor_gitrepo branch from f92fa33 to d19dc35 Compare October 5, 2025 07:36
@wxiaoguang wxiaoguang force-pushed the lunny/refactor_gitrepo branch from d19dc35 to 0e834b0 Compare October 5, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxiaoguang wxiaoguang wxiaoguang left review comments

+1 more reviewer

@hiifong hiifong hiifong approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/go Pull requests that update Go code modifies/migrations type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.26.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lunny @wxiaoguang @hiifong @GiteaBot