service/dap: honor the frame and goroutine of the SetVariable scope - #4419
Open
larrasket wants to merge 1 commit into
Open
service/dap: honor the frame and goroutine of the SetVariable scope#4419larrasket wants to merge 1 commit into
larrasket wants to merge 1 commit into
Conversation
onSetVariableRequest hardcoded goid, frame := -1, 0, so setting a local in a non-top stack frame either failed to find the variable or silently mutated the same-named local in frame 0. The sibling scopes/evaluate/ setDataBreakpoint handlers already thread frame context from the handle; only setVariable did not. Carry the scope's goroutine and frame index on the variable handle, propagate them to child handles, and use them in onSetVariableRequest. Fixes go-delve#3171
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
onSetVariableRequest hardcoded goid, frame := -1, 0, setting a local in a non-top stack frame is either: failed to find the variable or silently mutated the same-named local in frame 0.
Carry the scope's goroutine and frame index on the variable handle, propagate them to child handles, and use them in onSetVariableRequest.
Fixes #3171