Add TYPES constant and .entailed_term factory to TermNote#2
Merged
Conversation
- Add TYPES hash with standard DCA termNote type values (usageStatus, termType, grammaticalGender, grammaticalNumber, partOfSpeech, entailedTerm) per ISO 30042:2019 - Add .entailed_term class method for creating cross-reference termNotes with type and target attributes - Add comprehensive spec with 14 tests covering types, serialization, and round-trip
…Doc, and comprehensive specs
- Add Tbx::DataElement shared concern (DRY) for data-category attributes
with InlineContent sub-concern for entity.noteText elements
- Add Tbx::Modules::{Min,Basic,Linguist,CoreTypes} with TYPES/VALUES
constants sourced from .tbxmd files
- Add TYPES constants on Admin, AdminNote, Descrip, TermNote, Ref,
Xref, Transac, TransacNote, Hi composed from module definitions
- Add VALUES constants on TermNote (picklist enums) and Transac
- Add Tbx::TermComp, TermCompGrp, TermCompSec from TermComp module
- Fix Sc model to match core RNG (remove type, subtype, target attrs)
- Add comprehensive YARD RubyDoc on all element classes tracing
schema/module sources
- Add reference schema files from 12 LTAC-Global repositories
- Add 119 new specs (165 total) covering TYPES/VALUES, DataElement,
TermComp, and XML round-trips
- Update README with schema/module/element coverage tables
- Update CLAUDE.md with DataElement and Modules patterns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds standard DCA termNote type constants and a convenience factory method for creating entailedTerm cross-references.
Changes
TYPESconstant hash onTbx::TermNotewith standard ISO 30042:2019 DCA type values:usageStatus,termType,grammaticalGender,grammaticalNumber,partOfSpeech,entailedTerm.entailed_term(target:, content: nil)factory method — creates aTermNotewithtype: "entailedTerm"and the giventarget(and optionalcontent).14 specs covering type constants, entailed_term creation, XML serialization, and round-trip.
Usage
Context
This unblocks glossarist-ruby TODO 04 (TBX cross-references via entailedTerm), enabling
ConceptToTbxTransformto maprelated_conceptsto<termNote type="entailedTerm" target="...">elements.