feat: model parity with glossarist-ruby and domain graph support#21
Merged
Conversation
- Add domain extraction to build-edges.js with domain-nodes.json output - Add extractDomainEdges to DatasetAdapter for runtime domain detection - Update GraphEngine with domain node type and per-lang edge dedup - Update GraphPanel with domain node rendering (rounded rect, purple) - Add domain display section to ConceptDetail.vue - Update vocabulary store to load domain nodes alongside edges - Add EDGE_TYPE constant and GraphEdge.lang field to types - Update test helpers and add domain/edge tests
- Replace flat gender/plurality with structured grammarInfo in Designation type and generate-data termToDesignation - Add full designation attributes: termType, absent, geographicalArea, prefix, usageInfo, fieldOfApplication, acronym/initialism/truncation, text, image - Add LocalizedConcept fields: classification, reviewType, script, system, lineageSourceSimilarity - Update LanguageDetail.vue to render grammarInfo and termType - Update TBX export to emit grammar info from grammarInfo objects - Fix release type from number to string in timeline test - Update language-detail test for grammarInfo structure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the vocabulary browser to use the new glossarist model structure from glossarist-ruby/glossarist-js, and adds domain edge support for the graph visualization.
Changes
Model parity
gl:gender/gl:pluralitywith structuredgl:grammarInfoarray (matching glossarist-js GrammarInfo model)termToDesignationto map grammar_info from YAML to structured JSON-LD, handle all designation subtypes (letter_symbol, graphical symbol)Domain graph support
domain-nodes.jsonwith concept countsextractDomainEdgesandloadDomainNodesmethodsType updates
Designationinterface with GrammarInfo, all new optional fieldsLocalizedConceptwith classification, reviewType, script, systemreleasetype changed fromnumbertostring(matches glossarist-ruby)EDGE_TYPEconstant,GraphEdge.lang,GraphNode.nodeTypeTesting