Open
Conversation
Added is_public to Plugin model, public_key and encrypted_access_key to TrustedService model and updated the plugins' endpoints.
13 tasks
ChasNelson1990
previously approved these changes
Jul 21, 2022
ChasNelson1990
approved these changes
Jul 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
description,is_publicandoriginto thePluginmodel (and migrations!);originis aForeignKeythat is set to None for origin plugins and it is a link to the origin plugin for copies of a plugin.public_keyandencrypted_access_keyto theTrustedServicemodel; for these fieldsNonevalues are allowed to facilitate the migration from the old to the new system, due to the fact that values for these fields must be generated by DOMINATE.plugin.pyandtrusted_service.py.relates to gliff-ai/roadmap#82
DO NOT MERGE!
Checklist:
Put an
xin the boxes that apply to this pull request (you can also fill these out after opening the pull request). If you're unsure about any of these, don't hesitate to leave a comment on this pull request!