Skip to content

refactor: standardize use of renderWithAppContext and mocks #2392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Nov 16, 2025
Merged

refactor: standardize use of renderWithAppContext and mocks #2392

merged 19 commits into from
Nov 16, 2025

Conversation

@setchy
Copy link
Member

@setchy setchy commented Nov 16, 2025 •
edited
Loading

Significant refactor of tests to consistently

  • use renderWithAppContext (guarantees using primer theme and styles)
  • Naming of any mock objects or mock functions
  • Use defaults in test-utils where possible
  • clearer separation between mock files

@setchy setchy marked this pull request as draft November 16, 2025 20:25
@github-actions github-actions bot added the refactor Refactoring of existing feature label Nov 16, 2025
@setchy
test: refactor render with app context
c41e965 
Signed-off-by: Adam Setch <[email protected]>
@setchy
test: refactor render with app context
7db05ba 
Signed-off-by: Adam Setch <[email protected]>
@setchy
test: refactor render with app context
e471b08 
Signed-off-by: Adam Setch <[email protected]>
@setchy
test: refactor render with app context
9b25f8d 
Signed-off-by: Adam Setch <[email protected]>
@setchy
test: refactor render with app context
e701b7f 
Signed-off-by: Adam Setch <[email protected]>
@setchy
test: refactor render with app context
7be9d31 
Signed-off-by: Adam Setch <[email protected]>
@setchy
test: refactor render with app context
4bc9976 
Signed-off-by: Adam Setch <[email protected]>
@setchy
test: refactor render with app context
2b4b1a5 
Signed-off-by: Adam Setch <[email protected]>
@setchy
test: refactor render with app context
f6b610e 
Signed-off-by: Adam Setch <[email protected]>
@setchy setchy changed the title refactor: tests to use custom renderWithAppContext refactor: standardize use of renderWithAppContext and mocks Nov 16, 2025
@setchy setchy marked this pull request as ready for review November 16, 2025 22:03
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 16, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@setchy setchy merged commit 36d4be8 into main Nov 16, 2025
14 checks passed
@setchy setchy deleted the test/util-render-app-context branch November 16, 2025 22:28
@github-actions github-actions bot added this to the Release 6.14.0 milestone Nov 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@afonsojramos afonsojramos Awaiting requested review from afonsojramos afonsojramos is a code owner

@bmulholland bmulholland Awaiting requested review from bmulholland bmulholland is a code owner

Assignees

No one assigned

Labels

refactor Refactoring of existing feature

Milestone

Release 6.14.0

Development

Successfully merging this pull request may close these issues.

2 participants

@setchy