Skip to content

Add devcontainer config to pin Node version from .nvmrc #1626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakecoffman merged 2 commits into from
Feb 27, 2026
Merged

Add devcontainer config to pin Node version from .nvmrc #1626

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a17c96
Initial plan
Copilot Feb 27, 2026
c6d8b50
Add devcontainer config to use Node version from .nvmrc
Copilot Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"postCreateCommand": "nvm install && nvm alias default $(cat .nvmrc) && npm install"
Copy link

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The postCreateCommand is missing nvm use between nvm install and npm install. After installing the Node version, you need to activate it with nvm use before running npm commands. The README.md (line 31) shows the established pattern: nvm install;nvm use. Without this, npm install may run with a different Node version than intended. Consider updating to: nvm install && nvm use && nvm alias default $(cat .nvmrc) && npm install

Suggested change
"postCreateCommand": "nvm install && nvm alias default $(cat .nvmrc) && npm install"
"postCreateCommand": "nvm install && nvm use && nvm alias default $(cat .nvmrc) && npm install"

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The devcontainer configuration uses npm install but the project consistently uses npm clean-install everywhere else (test.yml:23, check-dist.yml:24, dependabot-build.yml:52, integration-test.yml:23). Using npm clean-install (or npm ci) ensures a clean, reproducible installation from package-lock.json, which is the established convention in this repository.

Suggested change
"postCreateCommand": "nvm install && nvm alias default $(cat .nvmrc) && npm install"
"postCreateCommand": "nvm install && nvm alias default $(cat .nvmrc) && npm clean-install"

Copilot uses AI. Check for mistakes.
}
Loading